paper/review-checks.md

Things to check with reviewers

@seaaan

In the "Using visdat" vignette, it says "missing data represented by black", but it shows up as gray on my computer.

I don't know why, but in the plotly section, a vis_dat() (non-interactive) plot of df_test appears between the first two interactive plots. I can't explain it, hopefully it's just a weird quirk on my computer.

Did you mean to export guess_type()?

vis_compare and vis_guess are indicated as being in beta, which seems also to apply to the plotly versions of the functions. The message that they emit is a helpful indication that they may change in the future. Before submitting to CRAN, however, you might consider moving those functions to the development version of the package and only uploading the functions with a stable API, then adding the beta version later once they stabilize. This is a judgment call; I think I tend towards being conservative on this issue personally.

task - create "dev" branch on github where I put the experimental features of visdat.



tierneyn/visdat documentation built on June 29, 2023, 9:40 p.m.