cran-comments.md

Oct 21, 2019, RAINBOWR version 0.1.8

Test environments

R CMD check results

There were no ERRORs.

There was 1 WARNING:

* checking data for ASCII and uncompressed saves ... WARNING

Note: significantly better compression could be obtained

by using R CMD build --resave-data old_size new_size compress Rice_Zhao_etal.RData 207Kb 105Kb xz

There were 4 NOTEs:

* checking CRAN incoming feasibility ... NOTE
* checking package dependencies ... NOTE

Package in Depends/Imports which should probably only be in LinkingTo:‘RcppEigen’

* checking examples ...

** running examples for arch 'i386' ... [13m] NOTE

** running examples for arch 'x64' ... [534s] NOTE Examples with CPU or elapsed time > 10s

Oct 22, 2019, RAINBOWR version 0.1.9 (resubmission)

Test environments

R CMD check results

There were no ERRORs.

There were no WARNINGs:

There were 1 NOTE:

* checking CRAN incoming feasibility ... NOTE

Oct 29, 2019, RAINBOWR version 0.1.10 (resubmission)

Major changes

We fixed some parts commented by the CRAN manager, Dr. Martina Schmirl. We will describe the comments and their solution as follows.

Please always explain all acronyms in the description text.

If there are references describing the methods in your package, please add these in the description field of your DESCRIPTION file in the form authors (year) authors (year) authors (year, ISBN:...) or if those are not available: with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for auto-linking.

You write information messages to the console that cannot be easily suppressed. Instead of print()/cat() rather use message()/warning() or if(verbose)cat(..) if you really have to write text to the console. (except for print() and summary() functions)

\dontrun{} should be only used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user. That's why wrapping examples in \dontrun{} adds the comment ("# Not run:") as a warning for the user. Does not seem necessary. Please unwrap the examples if they are executable in < 5 sec, or create additionally small toy examples to allow automatic testing. (You could also replace \dontrun{} with \donttest if it takes longer than 5 sec to be executed, but it would be preferable to have automatic checks for functions.)

Test environments

R CMD check results

The same results as those of the previous version 0.1.9 were obtained as follows.

There were no ERRORs.

There were no WARNINGs:

There were 1 NOTE:

* checking CRAN incoming feasibility ... NOTE

Nov 2, 2019, RAINBOWR version 0.1.11 (resubmission)

Major changes

We fixed some parts commented by the CRAN manager, Dr. Martina Schmirl. We will describe the comments and their solution as follows.

The package cannot be copyright holder of the package. (license file.)

Please ensure that your functions do not write by default or in your examples/vignettes/tests in the user's home filespace (including the package directory and getwd()). That is not allowed by CRAN policies. Please only write/save files if the user has specified a directory in the function themselves. Therefore please omit any default path = getwd() in writing functions. In your examples/vignettes/tests you can write to tempdir(). e.g. genetrait.R, ...

You still write information messages to the console that cannot be easily suppressed. It is more R like to generate objects that can be used to extract the information a user is interested in, and then print() that object. Instead of print()/cat() rather use message()/warning() or if(verbose)cat(..) if you really have to write text to the console. (except for print() and summary() functions)

However, there is still a dontrun in EMM.cpp.Rd Also we would appreciate it to have examples for automatic test so you can wrap unrealistic examles in \dontshow. Then we can have the checks and the users do not see those examples.

Test environments

R CMD check results

The same results as those of the previous version 0.1.9 were obtained as follows.

There were no ERRORs.

There were no WARNINGs:

There were 1 NOTE:

* checking CRAN incoming feasibility ... NOTE

Nov 6, 2019, RAINBOWR version 0.1.12 (resubmission)

Major changes

We fixed some parts commented by the CRAN manager, Dr. Swetlana Herbrandt. We will describe the comments and their solution as follows.

please write package names, software names and API names in single quotes (e.g. 'RAINBOWR') in your Description text.

You are changing the user's par() settings in your functions. Please ensure with an immediate call of on.exit() that the settings are reset.

Test environments

R CMD check results

The same results as those of the previous version 0.1.9 were obtained as follows.

There were no ERRORs.

There were no WARNINGs:

There were 1 NOTE:

* checking CRAN incoming feasibility ... NOTE

Nov 8, 2019, RAINBOWR version 0.1.13 (resubmission)

Major changes

We fixed some parts commented by the CRAN manager, Dr. Jelena Saf. We will describe the comments and their solution as follows.

Please shorten the title to a maximum of 65 characters.

Please make sure that you do not change the user's options, par or working directory. If you really have to do so, please ensure with an immediate call of on.exit() that the settings are reset when the function is exited, similar to this:

oldpar <- par(no.readonly = TRUE)
on.exit(par(oldpar))
par(mar = c(3, 3, 3, 6), xpd = T)
plot(x, y, cex = pl.size, xlim = c(0, max(cum.pos)), ylim = c(0, max(cum.pos)),
col = col.id[col.num], pch = 1)

The checktime of 664 seconds exceeds the limit of 10 minutes. Please add small executable examples in your Rd-files to illustrate the use of the exported function but also enable automatic testing.

Test environments

R CMD check results

The same results as those of the previous version 0.1.9 were obtained as follows.

There were no ERRORs.

There were no WARNINGs:

There were 1 NOTE:

* checking CRAN incoming feasibility ... NOTE

Nov 14, 2019, RAINBOWR version 0.1.14 (resubmission)

Major changes

We fixed some parts commented by the CRAN manager, Dr. Brian D. Ripley. We will describe the comments and their solution as follows.

See the CRAN check results page for your package, https://cran.r-project.org/web/checks/check_results_RAINBOWR.html . You were warned in 'Writing R Extensions' that calling math functions such as log pow sqrt with integer arguments is not portable.

EMM_functions.cpp: In function ‘Rcpp::List spectralG_eigen(Rcpp::NumericMatrix, Rcpp::NumericMatrix, bool, bool)’: EMM_functions.cpp:1216:25: error: call of overloaded ‘sqrt(const int&)’ is ambiguous double offset = sqrt(n);

const int n(X.rows()), p(X.cols());   # L1207

double offset = sqrt(n);            # L1215
const double n(X.rows()), p(X.cols());   # L1207

double offset = std::sqrt(n);            # L1215

Test environments

R CMD check results

The same results as those of the previous version 0.1.9 were obtained as follows.

There were no ERRORs.

There were no WARNINGs:

There were 1 NOTE:

* checking CRAN incoming feasibility ... NOTE

Nov 16, 2019, RAINBOWR version 0.1.15

Major changes

We fixed some parts related to the treatment of the missing in marker genotypes.

M.now <- Z.A[not.NA, ] %*% M
if (sum(is.na(M)) == 0) {
M.now <- Z.A[not.NA, ] %*% M
} else {
M.now <- M[apply(Z.A[not.NA, ], 1, function(x) which(x == 1)), ]
}

Apr 28, 2020, RAINBOWR version 0.1.16

Major changes

Test environments

R CMD check results

The same results as those of the previous version 0.1.9 were obtained as follows.

There were no ERRORs.

There were no WARNINGs:

There were 1 NOTE:

* checking CRAN incoming feasibility ... NOTE

Apr 29, 2020, RAINBOWR version 0.1.17

Major changes

Found the following (possibly) invalid URLs:
URL: https://cran.r-project.org/web/packages/RAINBOWR/index.html
From: inst/doc/RAINBOWR.html
README.md
Status: 200
Message: OK
CRAN URL not in canonical form
The canonical URL of the CRAN page for a package is
https://CRAN.R-project.org/package=pkgname

Then, we fixed this by using the canonical URL of the CRAN package "https://cran.r-project.org/package=RAINBOWR" in inst/doc/RAINBOWR.html and README.md files.

Test environments

R CMD check results

The same results as those of the previous version 0.1.9 were obtained as follows.

There were no ERRORs.

There were no WARNINGs:

There were 1 NOTE:

* checking CRAN incoming feasibility ... NOTE

Mar 19, 2020, RAINBOWR version 0.1.18

Major changes

Jul 22, 2020, RAINBOWR version 0.1.19

Major changes

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Aug 01, 2020, RAINBOWR version 0.1.20

Major changes

Aug 18, 2020, RAINBOWR version 0.1.21

Major changes

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Oct 29, 2020, RAINBOWR version 0.1.22

Major changes

Nov 03, 2020, RAINBOWR version 0.1.23

Major changes

Nov 11, 2020, RAINBOWR version 0.1.24

Major changes

Dec 15, 2020, RAINBOWR version 0.1.25

Major changes

Jan 19, 2021, RAINBOWR version 0.1.26

Major changes

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Apr 06, 2021, RAINBOWR version 0.1.27

Major changes

Jan 05, 2022, RAINBOWR version 0.1.28

Major changes for correcting errors pointed by CRAN maintainers

Major changes (new functions, etc...)

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Jan 06, 2022, RAINBOWR version 0.1.29

Major changes for correcting errors pointed by CRAN maintainers

Major changes

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Feb 01, 2022, RAINBOWR version 0.1.30

Major changes (new functions, etc...)

Jun 25, 2022, RAINBOWR version 0.1.31

Major changes (new functions, etc...)

Jul 25, 2023, RAINBOWR version 0.1.32

Major changes (new functions, etc...)

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Sep 11, 2023, RAINBOWR version 0.1.33

Major changes (new functions, etc...)

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Oct 2, 2023, RAINBOWR version 0.1.34

Major changes (new functions, etc...)

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Mar 03, 2024, RAINBOWR version 0.1.35

Major changes (new functions, etc...)

Test environments

R CMD check results

Status: OK

There were no ERRORs.

There were no WARNINGs.

There were no NOTEs.

Mar 21, 2024, RAINBOWR version 0.1.36

Major changes (new functions, etc...)

Dec 05, 2024, RAINBOWR version 0.1.37

Major changes (new functions, etc...)



KosukeHamazaki/RAINBOWR documentation built on Dec. 9, 2024, 12:06 a.m.