scalar_in_linter: Block usage like x %in% "a"

In jimhester/lintr: A 'Linter' for R Code

Block usage like x %in% "a"

Description

vector %in% set is appropriate for matching a vector to a set, but if that set has size 1, == is more appropriate. ⁠%chin%⁠ from {data.table} is matched as well.

Usage

scalar_in_linter()

Details

scalar %in% vector is OK, because the alternative (any(vector == scalar)) is more circuitous & potentially less clear.

Tags

best_practices, consistency, efficiency, readability

See Also

linters for a complete list of linters available in lintr.

Examples

# will produce lints
lint(
  text = "x %in% 1L",
  linters = scalar_in_linter()
)

lint(
  text = "x %chin% 'a'",
  linters = scalar_in_linter()
)

# okay
lint(
  text = "x %in% 1:10",
  linters = scalar_in_linter()
)

jimhester/lintr documentation built on April 24, 2024, 8:21 a.m.