cran-comments.md

In DavisVaughan/hardhat: Construct Modeling Packages

R CMD check results

0 errors | 0 warnings | 0 notes

revdepcheck results

We checked 7 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

• We saw 0 new problems
• We failed to check 0 packages

0.1.6 Submission

This submission adds a new family of extract_*() generics for usage in other tidymodels packages. It also formally removes support for logical indicators in default_formula_blueprint(), which has been soft deprecated for awhile now.

0.1.5 Submission

This submission adds limited support for sparse matrix output.

0.1.4 Submission

This submission tweaks the indicators argument of default_formula_blueprint() to allow for one hot encoding. It also fixes a small bug with character columns.

0.1.3 Submission

This submission keeps hardhat up to date with vctrs 0.3.0 and fixes a few bugs regarding novel factor levels.

0.1.2 Submission

This submission fixes a stringsAsFactors note and slightly tweaks how recipes are preprocessed.

0.1.1 Submission

This submission fixes the test error from the new recipes 0.1.8 update.

0.1.0 Resubmission

Review 3 - 2019-12-06

You have examples for unexported functions which cannot run in this way. Please either add hardhat::: to the function calls in the examples, omit these examples or export these functions. e.g. scream(), shrink(), in scream.Rd and shrink.Rd

Both scream() and shrink() are already exported, and their help files do not use any unexported functions.

\dontrun{} should only be used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user. That's why wrapping examples in \dontrun{} adds the comment ("# Not run:") as a warning for the user. Does not seem necessary. Please unwrap the examples if they are executable in < 5 sec, or replace \dontrun{} with \donttest{}.

Removed all uses of \dontrun{}.

Please add \value to .Rd files regarding exported methods and explain the functions results in the documentation. (See: Writing R Extensions https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Documenting-functions ) If a function does not return a value, please document that too, e.g. \value{None}.

Added return value descriptions for all exported functions.

Review 2 - 2019-11-28

Please omit the redundant 'Toolkit for' from your title.

Changed the Title from "A Toolkit for the Construction of Modeling Packages" to "Construct Modeling Packages".

The Description field is intended to be a (one paragraph) description of what the package does and why it may be useful. Please elaborate.

Changed the Description from:

"Provides infrastructure for building new modeling packages, including functionality around preprocessing, predicting, and validating input."

to:

"Building modeling packages is hard. A large amount of effort generally goes into providing an implementation for a new method that is efficient, fast, and correct, but often less emphasis is put on the user interface. A good interface requires specialized knowledge about S3 methods and formulas, which the average package developer might not have. The goal of 'hardhat' is to reduce the burden around building new modeling packages by providing functionality for preprocessing, predicting, and validating input."

If there are references describing (the theoretical backgrounds of) the methods in your package, please add these in the description field of your DESCRIPTION file in the form authors (year) authors (year) authors (year, ISBN:...) or if those are not available: with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for auto-linking.

There are no references for the methods in this package.

Review 1 - 2019-11-21

Found the following (possibly) invalid URLs: URL: https://github.com/tidymodels/hardhat/actions?workflow=R-CMD-check From: README.md Status: 404 Message: Not Found

Removed invalid URL link as requested. It is valid when signed in to GitHub, but 404s otherwise.

DavisVaughan/hardhat documentation built on Oct. 5, 2021, 9:53 a.m.