tests/testthat/test_Clean.R

In cleangeo: Cleaning Geometries from Spatial Objects

# test_Clean.R
# Author: Emmanuel Blondel <emmanuel.blondel1@gmail.com>
#
# Description: Unit tests for clgeo_Clean.R
#=======================
require(cleangeo, quietly = TRUE)
require(sp)
require(testthat)

context("clgeo_Clean")

file <- system.file("extdata", "example.shp", package = "cleangeo")
sf <- sf::st_read(file)
sp = as(sf, "Spatial")
sp.ids <- sapply(slot(sp, "polygons"), slot, "ID")
report <- NULL
nv <- NULL

#CollectionReport
test_that("clgeo_CollectionReport",{
  
  report <<- clgeo_CollectionReport(sp)
  expect_is(report, "data.frame")
  expect_equal(nrow(report), 3L)
 
  expect_equal(as.character(report[2,"type"]), "geos_error_validity")
  expect_equal(as.character(report[2,"issue_type"]), "GEOM_VALIDITY")
  expect_equal(as.character(report[3,"type"]), "geos_error_validity")
  expect_equal(as.character(report[3, "issue_type"]), "GEOM_VALIDITY")
  
})

#SuspiciousFeatures
test_that("clgeo_SuspiciousFeatures",{
  nv <<- clgeo_SuspiciousFeatures(report)
  expect_equal(length(nv), 2L)
  expect_equal(nv, c(2,3))
})

#Clean
test_that("clgeo_Clean",{
  sp.fixed <- clgeo_Clean(sp, verbose = FALSE)
  
  #data integrity
  expect_equal(sapply(slot(sp.fixed, "polygons"), slot, "ID"), sp.ids)
  
  #cleaning results
  report.fixed <- clgeo_CollectionReport(sp.fixed)
  nv.fixed <- clgeo_SuspiciousFeatures(report.fixed)
  expect_true(all(report.fixed[,"valid"]))
  expect_equal(nv.fixed, NA)
})

#Clean cases
#(list of cases taken from https://github.com/tudelft3d/prepair)

#validation is OK (managed by cleangeo)
test_that("Clean - 'bowtie' polygons",{
  wkt <- "POLYGON((0 0, 0 10, 10 0, 10 10, 0 0))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

#validation is OK (managed by cleangeo)
test_that("Clean - 'bowtie' polygons with holes",{
  
  wkt <- "POLYGON((0 0, 0 5, 3 10, 0 10, 10 0, 10 10, 0 0),(1 3, 2 3, 2 3, 1 3, 1 3))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
  
  wkt <- "POLYGON((0 0, 0 5, 3 10, 0 10, 10 0, 10 10, 0 0),(1 3, 2 3, 2 4, 1 4, 1 3),
          (7 5, 7 6, 8 6, 8 5, 7 5))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
  
  wkt <- "POLYGON((0 0, 0 5, 3 10, 0 10, 10 0, 10 10, 0 0),(1 3, 2 3, 2 4, 1 4, 1 3),
          (7 5, 7 6, 8 6, 8 5, 7 5),(7 3.5, 7 4, 8 4, 7 3.5))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
  
  wkt <- "POLYGON((0 0, 0 5, 3 10, 0 10, 10 0, 10 10, 0 0),(1 3, 2 3, 2 4, 1 4, 1 3),
          (7 5, 7 6, 8 6, 8 5, 7 5),(7 3.5, 7 4, 8 3.5, 8 4, 7 3.5))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
  
})

#validation is OK (managed by rgeos)
test_that("Clean - Square with wrong orientation",{
  wkt <- "POLYGON((0 0, 0 10, 10 10, 10 0, 0 0))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  expect_true(sf::st_is_valid(sf::st_as_sf(sp)))
})

#validation is OK (managed by cleangeo)
test_that("Clean - Inner ring with one edge sharing part of an edge of the outer ring",{
  wkt <- "POLYGON((0 0, 10 0, 10 10, 0 10, 0 0),(5 2,5 7,10 7, 10 2, 5 2))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

#validation is OK (managed by cleangeo)
test_that("Clean - Two adjacent inner rings",{
  wkt <- "POLYGON((0 0, 10 0, 10 10, 0 10, 0 0), (1 1, 1 8, 3 8, 3 1, 1 1), (3 1, 3 8, 5 8, 5 1, 3 1))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

#validation is OK (managed by cleangeo)
test_that("Clean - Nested polygon",{
  wkt <- "POLYGON((0 0, 10 0, 10 10, 0 10, 0 0), (2 8, 5 8, 5 2, 2 2, 2 8), (3 3, 4 3, 3 4, 3 3))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

#validation is OK (managed by cleangeo)
test_that("Clean - Nested polygon",{
  wkt <- "POLYGON((0 0, 10 0, 10 10, 0 10, 0 0), (1 1, 9 1, 9 9, 1 9, 1 1),
                  (2 2, 8 2, 8 8, 2 8, 2 2))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

#validation is OK (managed by cleangeo)
test_that("Clean - Multiple nested polygon",{
  wkt <- "POLYGON((0 0, 10 0, 10 10, 0 10, 0 0), (1 1, 9 1, 9 9, 1 9, 1 1),
                  (2 2, 8 2, 8 8, 2 8, 2 2),(3 3, 7 3, 7 7, 3 7, 3 3))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
  
  wkt <- "POLYGON((0 0, 10 0, 10 10, 0 10, 0 0), (1 1, 9 1, 9 9, 1 9, 1 1),
                  (2 2, 8 2, 8 8, 2 8, 2 2),(3 3, 7 3, 7 7, 3 7, 3 3),
                  (4 4, 6 4, 6 6, 4 6, 4 4))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

#validation is OK (managed by cleangeo)
test_that("Clean - Dangling edge",{
  wkt <- "POLYGON((0 0, 10 0, 15 5, 10 0, 10 10, 0 10, 0 0))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

test_that("Clean - false holes - case 1",{
  wkt <- "POLYGON((0 0, 0 10, 10 10, 10 5, 5 5, 5 7, 3 7, 3 5, 5 5, 5 0, 0 0))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

test_that("Clean - false holes - case 2",{
  wkt <- "POLYGON((0 0, 0 10, 10 10, 10 5, 3 5, 3 7, 5 7, 5 0, 0 0))"
  sp = as(sf::st_sf(id = 1, geom = sf::st_as_sfc(wkt), crs = 4326), "Spatial")
  sp.clean <- clgeo_Clean(sp)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})

test_that("Clean - false polygons",{
  sp <- SpatialPolygons(
    Srl = list(Polygons(
      srl = list(Polygon(as.matrix(data.frame(x=c(0,10,0),y=c(0,10,0))))),
      ID="1"
    ))
  )
  sp.clean <- clgeo_Clean(sp, verbose = TRUE)
  expect_false(sf::st_is_valid(sf::st_as_sf(sp)))
  expect_true(sf::st_is_valid(sf::st_as_sf(sp.clean)))
})